Slb/ad/cadenza 38410 #74
Merged
+47
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkissel
requested changes
Nov 26, 2024
CHANGELOG.md
Outdated
| @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
| This project uses a version scheme based on the Cadenza main version in the format x.x.y, where x.x is the Cadenza main version and y a functional change or bugfix. | |||
|
|
|||
| ## Unreleased | |||
| ### Fixed | |||
| - Removed duplicate geometry section in `sandbox.html#editGeometry` | |||
| - Horizontal scrollbar in `sandbox.html` left sidebar now appears sticky. | |||
There was a problem hiding this comment.
A Horizontal scrollbar is rather painful to use. Why do we want it here?
There was a problem hiding this comment.
We currently have it due to long explaination texts, and this is a improvement to the current state imo.
There was a problem hiding this comment.
But the sidebar is fixed width. We should be able to craft the contents in a way that does not require a horizontal scrollbar. For example texts should wrap lines. We can have a look if necessary.
added 5 commits
November 26, 2024 11:28
… it back to showMap.
…ollbar" This reverts commit 2b1078b.
klschm
reviewed
Nov 26, 2024
CHANGELOG.md
Outdated
| - Removed duplicate geometry section in `sandbox.html#editGeometry` | ||
|
|
||
| ### Changed | ||
| - Examples are now displayed more compact |
There was a problem hiding this comment.
- Examples in the sandbox now are displayed more compact
There was a problem hiding this comment.
Or:
Improved the examples in the sandbox to avoid a horizontal scrollbar.
klschm
approved these changes
Nov 26, 2024
jkissel
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.