Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in a few more tests #35

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Adding in a few more tests #35

wants to merge 16 commits into from

Conversation

kelmryan
Copy link
Contributor

I did not update the TOC. I believe you said you had a script for that? I tried to add a reference to the top after each

@danieldanielecki
Copy link
Member

Hey @kelmryan, I appreciate (again) for the contribution.

Would you happen to know how to update your branch? The changes you have are up to date with this repository.
It'd resolve conflicts because I can't merge these changes now. Plus, it'd simplify my job.

Screenshot 2024-08-24 at 17 54 13

Screenshot 2024-08-24 at 17 54 47

@kelmryan
Copy link
Contributor Author

I am having trouble resolving conflicts in VS studio just because the file is so big. Let me try andd see if I can resolved them

@kelmryan
Copy link
Contributor Author

Let me know if that rebase didn't work

@danieldanielecki
Copy link
Member

Let me know if that rebase didn't work

It looks much better now, thank you. I'll review & merge this changes later, when my agenda will be a bit more relaxed!

README.md Outdated
@@ -1,4 +1,4 @@
# ⬆️ Amazon Web Services Certified (AWS Certified) Solutions Architect Associate (SAA-C03) Practice Tests Exams Questions & Answers
*# ⬆️ Amazon Web Services Certified (AWS Certified) Solutions Architect Associate (SAA-C03) Practice Tests Exams Questions & Answers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need the star here?:)

@danieldanielecki
Copy link
Member

@kelmryan this PR is quite big, that's why I'm first clearing other issues/PR's/bugs, but hoping to take a look...

Why do we need the Python script? Might you please explain?

@danieldanielecki
Copy link
Member

This PR also has quite some formatting changes, which I'll need to find time to manually copy/paste in a separate commit, so I'm taking my time...

@kelmryan kelmryan closed this Dec 22, 2024
@danieldanielecki
Copy link
Member

I'll review it, no worries @kelmryan, but the PR itself is big, and has formatting changes includes, so it'll take a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants