-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix attemp #45
fix attemp #45
Conversation
34ce330
to
7d49ebe
Compare
@eduardconstantin, what do you think? The user has reported a bug via Reddit, @zhuoyuT might you confirm that's what is the PR about? |
someone else implemented the scoring, I believe this happens because some questions have multiple answers and the score is divided by the number of answers |
@danieldanielecki @eduardconstantin |
even better |
thanks for the clarification, will be waiting for the next commits :) |
7d49ebe
to
737ef61
Compare
@eduardconstantin @danieldanielecki PR updated, please check |
Is it now 100% fixed & ready? |
What I understood before this fix when there was a question with multiple answers correct, the total result wasn't calculated correctly. Now it should be fixed, and easily noticed by seeing 100% for such tests in Practice Mode. Might you please confirm? |
I assumed that was the issue, I haven't checked |
I tested, and it was indeed the case. However, regardless of the number of multiple-choice questions, the maximum score was always |
and it's no longer the case, thank you so much for the contribution @zhuoyuT @eduardconstantin, I also made the counter of answered questions in the top left a bit more explicit by adding |
@@ -19,7 +19,7 @@ const Modes: NextPage<{ searchParams: { url: string; name: string } }> = ({ | |||
<ExamLink | |||
href={{ | |||
pathname: "/practice", | |||
query: { url }, | |||
query: { url, name }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for aligning it with the root page query
not a bad idea, but now the top part is not centered anymore :( |
uhh good feedback, missed it. Any idea how to handle both? |
used emoji instead 5ac85c3 and now having best of both ;) |
I meant Exam Mode of course. Practice Mode has no results shown. |
Fixes #0000
Pull Request Type
Summary