Fix to Eloquent Destination to ensure casting functions as expected w…

…hen rows are updated
DivineOmega · Mar 27, 2019 · b46f62a · b46f62a
1 parent 92ef459
commit b46f62a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Objects/Destinations/EloquentDestination.php b/src/Objects/Destinations/EloquentDestination.php
@@ -46,11 +46,15 @@ private function updateDataRow(DataRow $dataRow)
     {
         $keyDataItems = $dataRow->getKeyDataItems();
 
-        $record = $this->model->where(function ($query) use ($keyDataItems) {
+        $records = $this->model->where(function ($query) use ($keyDataItems) {
             foreach ($keyDataItems as $keyDataItem) {
                 $query->where($keyDataItem->fieldName, $keyDataItem->value);
             }
-        })->update($this->getAssocArrayFromDataRow($dataRow));
+        })->get();
+
+        foreach($records as $record) {
+            $record->update($this->getAssocArrayFromDataRow($dataRow));
+        }
     }
 
     public function putDataRows(array $dataRows)

diff --git a/tests/Unit/EloquentDestinationTest.php b/tests/Unit/EloquentDestinationTest.php
@@ -18,7 +18,8 @@ private function getDestination()
         $stmt = $this->pdo->prepare($sql);
         $stmt->execute();
 
-        $sql = 'CREATE TABLE IF NOT EXISTS users (name TEXT, value INTEGER)';
+
+        $sql = 'CREATE TABLE IF NOT EXISTS users (id integer primary key autoincrement, name TEXT, value INTEGER)';
         $stmt = $this->pdo->prepare($sql);
         $stmt->execute();
 
@@ -60,7 +61,7 @@ private function alterDataRows(array $dataRows)
 
     private function getActualArray()
     {
-        $sql = 'SELECT * FROM users';
+        $sql = 'SELECT name, value FROM users';
         $stmt = $this->pdo->prepare($sql);
         $stmt->execute();