Ensure PDO source can gracefully handle reading from a table with no …

…data
DivineOmega · Feb 24, 2020 · c82d364 · c82d364
1 parent 3015bb0
commit c82d364
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/src/Objects/Sources/PDOSource.php b/src/Objects/Sources/PDOSource.php
@@ -38,7 +38,7 @@ protected function getTableFields()
 
         $row = $stmt->fetch(PDO::FETCH_ASSOC);
 
-        $tableFields = array_keys($row);
+        $tableFields = is_array($row) ? array_keys($row) : [];
 
         return $tableFields;
     }

diff --git a/tests/Unit/Data/source.sqlite b/tests/Unit/Data/source.sqlite
diff --git a/tests/Unit/PDOSourceTest.php b/tests/Unit/PDOSourceTest.php
@@ -165,4 +165,25 @@ public function testCountPages()
 
         $this->assertEquals(1, $source->countPages());
     }
+
+    private function createEmptyTableSource()
+    {
+        return new PDOSource(new PDO('sqlite:'.__DIR__.'/Data/source.sqlite'), 'empty_table');
+    }
+
+    public function testGetFieldsOnEmptyTable()
+    {
+        $source = $this->createEmptyTableSource();
+
+        $this->assertEquals([], $source->getFields());
+    }
+
+    public function testGetDataRowsOnEmptyTable()
+    {
+        $source = $this->createEmptyTableSource();
+
+        $dataRows = $source->getDataRows(1, ['thing1', 'thing2']);
+
+        $this->assertCount(0, $dataRows);
+    }
 }