Replace libdparse with DMD in VcallCtorChecker #145
Conversation
Weird, it seems that dub does not know, or cannot find permissivevisitor.d . What the heck? |
|
Got it, it seems that the file has been moved to a different file: dlang/dmd#16875 |
|
This will prolly fix it: dlang/dmd#16906 |
Vladiwostok
force-pushed
the
vcall-in-ctor
branch
from
c9ca7c9
to
43d6e7a
Compare
| private enum string KEY = "dscanner.vcall_ctor"; | ||
| private enum string MSG = "a virtual call inside a constructor may lead to unexpected results in the derived classes"; | ||
|
|
||
| private static struct FuncContext |
There was a problem hiding this comment.
It seems like you doubled the tab size. Why?
There was a problem hiding this comment.
I haven't doubled the tab size. I used dfmt to automatically format the file. It was done using tab characters with 4 spaces. Before only spaces were used. I think github shows a wider spacing to differentiate between normal spaces and tabs.
There was a problem hiding this comment.
Then maybe try dfmt with 4 spaces instead of tabs?
There was a problem hiding this comment.
I'm using a single TAB character (1 char in bottom right corner of the screenshot) that has the standard size of 4 spaces
There was a problem hiding this comment.
Does D's standard style use spaces instead of tabs?
There was a problem hiding this comment.
In dmd yes, we have spaces. I think what we are seing here is how a tab is interpreted (default to 4 spaces on your machine, default to 8 on github). Just use spaces and let's not waste more time on this nonsense.
| import dscanner.analysis.helpers : assertAnalyzerWarnings; | ||
| import std.stdio : stderr; | ||
| import std.format : format; | ||
| import dscanner.analysis.config : StaticAnalysisConfig, Check, disabledConfig; |
#78 cont
This time without full semantic
I've also did my best to stick to the old libdparse implementation this time