Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(beta) NSF driver N163 Vxx wave index can access out-of-bounds memory #299

Open
Gumball2415 opened this issue Oct 5, 2024 · 1 comment · May be fixed by #262
Open

(beta) NSF driver N163 Vxx wave index can access out-of-bounds memory #299

Gumball2415 opened this issue Oct 5, 2024 · 1 comment · May be fixed by #262
Labels
beta Applies to a beta/indev version bug Something isn't working nsf-driver sound engine used in NSF/assembly file export

Comments

@Gumball2415
Copy link
Collaborator

on build 72f32a6, N163 wavetables are not written correctly(?)

test module and exported .nsf for reference
the mind electric.zip
@eulyderg eulyderg added bug Something isn't working beta Applies to a beta/indev version labels Nov 17, 2024
@Gumball2415 Gumball2415 added the nsf-driver sound engine used in NSF/assembly file export label Nov 23, 2024
@Gumball2415 Gumball2415 changed the title (beta) NSF driver N163 wavetable export corruption? (beta) NSF driver N163 Vxx wave index can access out-of-bounds memory Dec 25, 2024
@Gumball2415
Copy link
Collaborator Author

update: there are no bounds checking when indexing the instrument wave data index. this means a Vxx command on an instrument with less waves than the effect parameter can access data out of bounds.

Gumball2415 added a commit that referenced this issue Dec 25, 2024
@Gumball2415
Check wave index bounds before indexing wave data
893e3ec 
Fixes #299.
@Gumball2415 Gumball2415 linked a pull request Dec 25, 2024 that will close this issue
Draft
Gumball2415 added a commit that referenced this issue Dec 25, 2024
@Gumball2415
Check wave index bounds before indexing wave data
81be243 
Fixes #299.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta Applies to a beta/indev version bug Something isn't working nsf-driver sound engine used in NSF/assembly file export
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NSF Driver and Export Fixes Dn-Programming-Core-Management/Dn-FamiTracker
2 participants
@eulyderg @Gumball2415