Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSF Driver Fixes #262

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

NSF Driver Fixes #262

wants to merge 35 commits into from

Conversation

Gumball2415
Copy link
Member

This pull request aims to fix various bugs regarding NSF driver export and execution.

This pull request improves upon and supercedes #156.

@Gumball2415
Fix N163 instrument load clobbering Kxx state
861f682 
Fixes #224.
Fixes #260.
Iterates upon #156.
@Gumball2415
Fix VRC7 period table assembly export
0954020
@Gumball2415
Fix S5B init clobbering Kxx state
31075be 
Fixes #256.
Fixes #246.
Fixes #215.
@Gumball2415
Implement "glob" multichip assembly export
e67e701
@Gumball2415
Write carrier frequency regardless of Kxx state
eeb7835 
Fixes #196.
@Gumball2415
Fix debug constexpr
e390204
@Gumball2415
Update effect bytecodes in row skip handling
3c08177 
Fixes #183.
@Gumball2415
Fix NSF driver phase reset behavior
b57faeb
@Gumball2415
Handle Gxx delay commands in both row and frame...
3ef2be3 
...transitions
Fixes #207.
@Gumball2415
Ignore invalid pattern data upon NSF export
c0d46f5 
Fixes #215.
@Gumball2415
Specify overflow in driver bank allocation
9abc231 
Refactor compressed mode calculation
@Gumball2415
Specify what parts of pattern data are invalid
716f8e6 
Differentiate between error and warning colors
@Gumball2415
Fix S5B instrument duty envelopes
04f6190 
Fixes #267.
@Gumball2415
Account for HOLD_INSTRUMENT in pattern checking
d7c481b
@Gumball2415
Include N163 period table in asm export
71f4f62
@Gumball2415
Clamp pitch and hi-pitch envelope period results
6f2c743
@Gumball2415 Gumball2415 force-pushed the app-emu-module-nsf_driver-dev branch from 39cb8f4 to 6f2c743 Compare March 22, 2024 17:57
@Gumball2415 Gumball2415 mentioned this pull request Jun 2, 2024
Open
@Gumball2415
Copy link
Member Author

TODO: fix linear pitch pitch sequences
TODO: fix filename handling with two filetype extensions

@Gumball2415
Copy link
Member Author

TODO: fix asm export DPCM start address issue with beep.dnm

@Gumball2415 Gumball2415 force-pushed the app-emu-module-nsf_driver-dev branch from 9e937ab to d92a3a1 Compare July 19, 2024 14:16
@Gumball2415
Copy link
Member Author

TODO: fix linear pitch pitch sequences

fixed in 4ce047d

TODO: fix asm export DPCM start address issue with beep.dnm

fixed in fa05bd9

@Gumball2415 Gumball2415 force-pushed the app-emu-module-nsf_driver-dev branch from 7eca46b to 718183d Compare July 22, 2024 10:36
@Gumball2415 Gumball2415 mentioned this pull request Jul 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gumball2415