Add a test for JSON parsing #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I replaced Utf8Json with System.Text.Json in #72. All tests passed, but it cannot guarantee stability in production, because serialization in Telegram Bot API a bit complex for strongly typed languages. I would like to write unit tests code generator, but it may take a while. |
|
If you build a preview version of the packages, I guess I can try integrating them in some of my bots, to see if they will still work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test I created while investigating codingteam/emulsion#190.
To summarize: there are no known DoS issues with the latest version of Funogram.
We should consider migrating away from Utf8Json, though, and this test may serve as one of the checks we'll perform before migration to another JSON library.