FIX compatibility with payment type sharing (Multicompany)

[hregis]

No description provided.

[hregis]

@mdeweerd how to fix this phan error ? thanks

[mdeweerd]

I already fied several notices in #32779 - I do not know which phan/phpstan notice you are interested in.

The only phan notice remaining in that PR is:

htdocs/comm/action/peruser.php#L1352
peruser.php: PhanTypeMismatchProperty: Assigning ($userId as a field) of type array<int,non-zero-int> to property but \ActionComm->userassigned is array<int,array{id:int,transparency:int}>

where ActionComm->userassigned is an array of arrays but a simple array is assigned.
That type for userassigned could be incorrect, but if it is incorrect then I think that other code using 'userassigned' also needs updates.

[hregis]

@eldy if it's ok, can I move this code into a new function in "functions.lib.php" in order to use it in other dictionaries, with a hook inside to have the possibility to customize it?
or in multicompany module !

[hregis]

je ne vais pas passer mon temps à corriger les erreurs phpstan des autres fichiers qui ne concernent pas ma PR !! 😄