enhance mutation observer callbacks

DominoKit · Dec 8, 2024 · 4e46aab · 4e46aab
1 parent 71073b9
commit 4e46aab
Show file tree

Hide file tree

Showing 41 changed files with 342 additions and 181 deletions.
diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/carousel/Carousel.java b/domino-ui/src/main/java/org/dominokit/domino/ui/carousel/Carousel.java
@@ -179,24 +179,20 @@ private void resetTimer() {
   }
 
   private void addDetachListener() {
-    ElementUtil.onDetach(
-        element(),
-        mutationRecord -> {
+    onDetached(
+        (Carousel, mutationRecord) -> {
           this.attached = false;
           this.stopAutoSlide();
         });
   }
 
   private void addAttachListener() {
-    ElementUtil.onAttach(
-        this.element(),
-        mutationRecord -> {
+    onAttached(
+        (target, mutationRecord) -> {
           this.attached = true;
           if (autoSlide) {
             timer.scheduleRepeating(autoSlideDuration);
           }
-
-          addDetachListener();
         });
   }
 

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/chips/ChipsGroup.java b/domino-ui/src/main/java/org/dominokit/domino/ui/chips/ChipsGroup.java
@@ -75,7 +75,7 @@ public ChipsGroup appendChild(Chip chip) {
     chip.setSelectable(true);
     chip.setRemovable(removable || chip.isRemovable());
     chip.onDetached(
-        mutationRecord -> {
+        (target, mutationRecord) -> {
           if (chip.isSelected()) {
             chip.deselect();
           }

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/collapsible/HeightCollapseStrategy.java b/domino-ui/src/main/java/org/dominokit/domino/ui/collapsible/HeightCollapseStrategy.java
@@ -156,7 +156,7 @@ public void collapse(Element element) {
             handlers.onCollapseCompleted().run();
           } else {
             self.onAttached(
-                mutationRecord -> {
+                (e, mutationRecord) -> {
                   this.target.setAttribute(DUI_EXPANDED_HEIGHT, "auto");
                   this.target.setCssProperty(this.heightVar, "auto");
                   this.handlers.onBeforeCollapse().run();

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/collapsible/TreeHeightCollapseStrategy.java b/domino-ui/src/main/java/org/dominokit/domino/ui/collapsible/TreeHeightCollapseStrategy.java
@@ -158,7 +158,7 @@ public void collapse(Element element) {
             handlers.onCollapseCompleted().run();
           } else {
             self.onAttached(
-                mutationRecord -> {
+                (e, mutationRecord) -> {
                   this.handlers.onBeforeCollapse().run();
                   treeItem.addCss(dui_transition_none);
                   collapseElement(element);

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/datatable/DataTable.java b/domino-ui/src/main/java/org/dominokit/domino/ui/datatable/DataTable.java
@@ -160,7 +160,7 @@ public DataTable(TableConfig<T> tableConfig, DataStore<T> dataStore) {
     initDynamicStyleSheet();
     init();
     onAttached(
-        mutationRecord -> {
+        (e, mutationRecord) -> {
           DomGlobal.setTimeout(
               p0 -> {
                 getDynamicStyleSheet().flush();

diff --git a/...o-ui/src/main/java/org/dominokit/domino/ui/datatable/plugins/column/PinColumnsPlugin.java b/...o-ui/src/main/java/org/dominokit/domino/ui/datatable/plugins/column/PinColumnsPlugin.java
@@ -134,7 +134,7 @@ public void init(DataTable<T> dataTable) {
                                     "col-pin-" + col.getName().replace(" ", "_"));
                               });
                     }));
-    this.datatable.onAttached(mutationRecord -> pinColumns());
+    this.datatable.onAttached((e, mutationRecord) -> pinColumns());
   }
 
   /**
@@ -485,7 +485,7 @@ private void pinColumns() {
       pinColumnsForAttachedTable();
     } else {
       datatable.onAttached(
-          mutationRecord -> DomGlobal.setTimeout(p0 -> pinColumnsForAttachedTable()));
+          (e, mutationRecord) -> DomGlobal.setTimeout(p0 -> pinColumnsForAttachedTable()));
     }
   }
 

diff --git a/...i/src/main/java/org/dominokit/domino/ui/datatable/plugins/column/ResizeColumnsPlugin.java b/...i/src/main/java/org/dominokit/domino/ui/datatable/plugins/column/ResizeColumnsPlugin.java
@@ -182,12 +182,12 @@ public void onHeaderAdded(DataTable<T> dataTable, ColumnConfig<T> column) {
                     };
 
                 this.datatable.onAttached(
-                    mutationRecord -> {
+                    (e, mutationRecord) -> {
                       DominoDom.document.body.addEventListener(
                           EventType.mouseup.getName(), stopResizing);
                     });
                 this.datatable.onDetached(
-                    mutationRecord -> {
+                    (e, mutationRecord) -> {
                       resizeElement.removeEventListener(EventType.mouseup.getName(), stopResizing);
                       DominoDom.document.body.removeEventListener(
                           EventType.mouseup.getName(), stopResizing);

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/datepicker/WeekDayHeader.java b/domino-ui/src/main/java/org/dominokit/domino/ui/datepicker/WeekDayHeader.java
@@ -63,7 +63,7 @@ public WeekDayHeader(IsCalendar calendar, int dayIndex) {
                         .textContent(
                             this.calendar.getDateTimeFormatInfo().weekdaysShort()[dayIndex]));
     init(this);
-    onDetached(mutationRecord -> this.calendar.unbindCalenderViewListener(this));
+    onDetached((e, mutationRecord) -> this.calendar.unbindCalenderViewListener(this));
   }
 
   /**

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/DateBox.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/DateBox.java
@@ -154,7 +154,7 @@ public DateBox(
                 popover -> {
                   withOpenOnFocusToggleListeners(false, field -> focus());
                 });
-    onDetached(mutationRecord -> popover.close());
+    onDetached((e, mutationRecord) -> popover.close());
 
     getInputElement()
         .onKeyDown(keyEvents -> keyEvents.onEnter(evt -> doOpen()).onSpace(evt -> doOpen()));

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/DateRangeBox.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/DateRangeBox.java
@@ -175,7 +175,7 @@ public DateRangeBox(
                 popover -> {
                   withOpenOnFocusToggleListeners(false, field -> focus());
                 });
-    onDetached(mutationRecord -> popover.close());
+    onDetached((e, mutationRecord) -> popover.close());
 
     getInputElement()
         .onKeyDown(keyEvents -> keyEvents.onEnter(evt -> doOpen()).onSpace(evt -> doOpen()));

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/InputFormField.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/InputFormField.java
@@ -27,7 +27,6 @@
 import org.dominokit.domino.ui.utils.ApplyFunction;
 import org.dominokit.domino.ui.utils.ChildHandler;
 import org.dominokit.domino.ui.utils.DominoElement;
-import org.dominokit.domino.ui.utils.ElementUtil;
 
 /**
  * An abstract base class for input form fields in Domino UI. InputFormField represents form fields
@@ -285,8 +284,12 @@ public void setValue(V value) {
   public T focus() {
     if (!isDisabled()) {
       if (!isAttached()) {
-        ElementUtil.onAttach(
-            getInputElement(), mutationRecord -> getInputElement().element().focus());
+        getInputElement()
+            .onAttached(
+                (target, mutationRecord) -> {
+                  getInputElement().element().focus();
+                });
+
       } else {
         getInputElement().element().focus();
       }
@@ -302,11 +305,11 @@ public T focus() {
   @Override
   public T unfocus() {
     if (!isAttached()) {
-      ElementUtil.onAttach(
-          getInputElement(),
-          mutationRecord -> {
-            getInputElement().element().blur();
-          });
+      getInputElement()
+          .onAttached(
+              (target, mutationRecord) -> {
+                getInputElement().element().blur();
+              });
     } else {
       getInputElement().element().blur();
     }

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/Radio.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/Radio.java
@@ -540,8 +540,11 @@ public String getStringValue() {
   public Radio<T> focus() {
     if (!isDisabled()) {
       if (!isAttached()) {
-        ElementUtil.onAttach(
-            getInputElement(), mutationRecord -> getInputElement().element().focus());
+        getInputElement()
+            .onAttached(
+                (target, mutationRecord) -> {
+                  getInputElement().element().focus();
+                });
       } else {
         getInputElement().element().focus();
       }
@@ -557,11 +560,11 @@ public Radio<T> focus() {
   @Override
   public Radio<T> unfocus() {
     if (!isAttached()) {
-      ElementUtil.onAttach(
-          getInputElement(),
-          mutationRecord -> {
-            getInputElement().element().blur();
-          });
+      getInputElement()
+          .onAttached(
+              (target, mutationRecord) -> {
+                getInputElement().element().blur();
+              });
     } else {
       getInputElement().element().blur();
     }

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/TextAreaBox.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/TextAreaBox.java
@@ -99,7 +99,7 @@ public TextAreaBox() {
     header.appendChild(
         headerFiller =
             FillerElement.create().addCss(dui_form_text_area_header_filler, dui_order_30));
-    onAttached(mutationRecord -> adjustHeight());
+    onAttached((e, mutationRecord) -> adjustHeight());
     setDefaultValue("");
     getInputElement().addCss(dui_h_inherit).setAttribute("data-scroll", "0");
     getInputElement()

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/TimeBox.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/TimeBox.java
@@ -128,7 +128,7 @@ public TimeBox(Date date, DateTimeFormatInfo dateTimeFormatInfo) {
                 popover -> {
                   withOpenOnFocusToggleListeners(false, field -> focus());
                 });
-    onDetached(mutationRecord -> popover.close());
+    onDetached((e, mutationRecord) -> popover.close());
 
     getInputElement()
         .onKeyDown(keyEvents -> keyEvents.onEnter(evt -> doOpen()).onSpace(evt -> doOpen()));

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/suggest/AbstractSelect.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/suggest/AbstractSelect.java
@@ -170,7 +170,7 @@ public AbstractSelect() {
             .addOpenListener((menu) -> focus());
 
     onAttached(
-        mutationRecord -> {
+        (e, mutationRecord) -> {
           optionsMenu.setTargetElement(getWrapperElement());
         });
     getInputElement()

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/suggest/AbstractSuggestBox.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/suggest/AbstractSuggestBox.java
@@ -159,7 +159,7 @@ public AbstractSuggestBox(SuggestionsStore<T, E, O> store) {
             .setRemoveLoadingText(true);
 
     onAttached(
-        mutationRecord -> {
+        (e, mutationRecord) -> {
           optionsMenu.setTargetElement(getWrapperElement());
         });
 

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/layout/AppLayout.java b/domino-ui/src/main/java/org/dominokit/domino/ui/layout/AppLayout.java
@@ -167,7 +167,7 @@ public AppLayout() {
     init(this);
 
     layout.onAttached(
-        mutationRecord ->
+        (e, mutationRecord) ->
             layout
                 .parent()
                 .addClickListener(

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/BounceLoader.java b/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/BounceLoader.java
@@ -91,13 +91,13 @@ public void setLoadingText(String text) {
    */
   @Override
   public void setSize(String width, String height) {
-    onAttached(mutationRecord -> loader.setWidth(width).setHeight(height));
+    onAttached((e, mutationRecord) -> loader.setWidth(width).setHeight(height));
   }
 
   /** Removes the loading text from the loader. */
   @Override
   public void removeLoadingText() {
-    onAttached(mutationRecord -> loadingText.remove());
+    onAttached((e, mutationRecord) -> loadingText.remove());
   }
 
   /**

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/BouncePulseLoader.java b/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/BouncePulseLoader.java
@@ -92,13 +92,13 @@ public void setLoadingText(String text) {
    */
   @Override
   public void setSize(String width, String height) {
-    onAttached(mutationRecord -> loader.setWidth(width).setHeight(height));
+    onAttached((e, mutationRecord) -> loader.setWidth(width).setHeight(height));
   }
 
   /** Removes the loading text from the loader. */
   @Override
   public void removeLoadingText() {
-    onAttached(mutationRecord -> loadingText.remove());
+    onAttached((e, mutationRecord) -> loadingText.remove());
   }
 
   /**

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/FacebookLoader.java b/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/FacebookLoader.java
@@ -93,13 +93,13 @@ public void setLoadingText(String text) {
    */
   @Override
   public void setSize(String width, String height) {
-    onAttached(mutationRecord -> loader.setWidth(width).setHeight(height));
+    onAttached((e, mutationRecord) -> loader.setWidth(width).setHeight(height));
   }
 
   /** Removes the loading text from the loader. */
   @Override
   public void removeLoadingText() {
-    onAttached(mutationRecord -> loadingText.remove());
+    onAttached((e, mutationRecord) -> loadingText.remove());
   }
 
   /**

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/IosLoader.java b/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/IosLoader.java
@@ -109,13 +109,13 @@ public void setLoadingText(String text) {
    */
   @Override
   public void setSize(String width, String height) {
-    onAttached(mutationRecord -> loader.setWidth(width).setHeight(height));
+    onAttached((e, mutationRecord) -> loader.setWidth(width).setHeight(height));
   }
 
   /** Removes the loading text from the loader. */
   @Override
   public void removeLoadingText() {
-    onAttached(mutationRecord -> loadingText.remove());
+    onAttached((e, mutationRecord) -> loadingText.remove());
   }
 
   /**

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/NoneLoader.java b/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/NoneLoader.java
@@ -84,7 +84,7 @@ public void setSize(String width, String height) {}
   /** Removes the loading text from the loader. */
   @Override
   public void removeLoadingText() {
-    onAttached(mutationRecord -> loadingText.remove());
+    onAttached((e, mutationRecord) -> loadingText.remove());
   }
 
   /**

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/OrbitLoader.java b/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/OrbitLoader.java
@@ -88,13 +88,13 @@ public void setLoadingText(String text) {
    */
   @Override
   public void setSize(String width, String height) {
-    onAttached(mutationRecord -> loader.setWidth(width).setHeight(height));
+    onAttached((e, mutationRecord) -> loader.setWidth(width).setHeight(height));
   }
 
   /** Removes the loading text from the loader. */
   @Override
   public void removeLoadingText() {
-    onAttached(mutationRecord -> loadingText.remove());
+    onAttached((e, mutationRecord) -> loadingText.remove());
   }
 
   /**

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/ProgressBarLoader.java b/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/ProgressBarLoader.java
@@ -86,13 +86,13 @@ public void setLoadingText(String text) {
    */
   @Override
   public void setSize(String width, String height) {
-    onAttached(mutationRecord -> loader.setWidth(width).setHeight(height));
+    onAttached((e, mutationRecord) -> loader.setWidth(width).setHeight(height));
   }
 
   /** Removes the loading text from the loader. */
   @Override
   public void removeLoadingText() {
-    onAttached(mutationRecord -> loadingText.remove());
+    onAttached((e, mutationRecord) -> loadingText.remove());
   }
 
   /**

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/PulseLoader.java b/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/PulseLoader.java
@@ -85,13 +85,13 @@ public void setLoadingText(String text) {
    */
   @Override
   public void setSize(String width, String height) {
-    onAttached(mutationRecord -> loader.setWidth(width).setHeight(height));
+    onAttached((e, mutationRecord) -> loader.setWidth(width).setHeight(height));
   }
 
   /** Removes the loading text from the loader. */
   @Override
   public void removeLoadingText() {
-    onAttached(mutationRecord -> loadingText.remove());
+    onAttached((e, mutationRecord) -> loadingText.remove());
   }
 
   /**

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/RotatePlaneLoader.java b/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/RotatePlaneLoader.java
@@ -86,13 +86,13 @@ public void setLoadingText(String text) {
    */
   @Override
   public void setSize(String width, String height) {
-    onAttached(mutationRecord -> loader.setWidth(width).setHeight(height));
+    onAttached((e, mutationRecord) -> loader.setWidth(width).setHeight(height));
   }
 
   /** Removes the loading text from the loader. */
   @Override
   public void removeLoadingText() {
-    onAttached(mutationRecord -> loadingText.remove());
+    onAttached((e, mutationRecord) -> loadingText.remove());
   }
 
   /**

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/RotationLoader.java b/domino-ui/src/main/java/org/dominokit/domino/ui/loaders/RotationLoader.java
@@ -86,13 +86,13 @@ public void setLoadingText(String text) {
    */
   @Override
   public void setSize(String width, String height) {
-    onAttached(mutationRecord -> loader.setWidth(width).setHeight(height));
+    onAttached((e, mutationRecord) -> loader.setWidth(width).setHeight(height));
   }
 
   /** Removes the loading text from the loader. */
   @Override
   public void removeLoadingText() {
-    onAttached(mutationRecord -> loadingText.remove());
+    onAttached((e, mutationRecord) -> loadingText.remove());
   }
 
   /**