fix #976 setCloseOnBlur Causes Unintended Behavior (Menu Closing) in …

…MultiSelect Component
DominoKit · Nov 17, 2024 · f601b7e · f601b7e
1 parent 6420519
commit f601b7e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/suggest/CheckOption.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/suggest/CheckOption.java
@@ -168,9 +168,10 @@ private void initCheckBox() {
                     });
 
                 menuItem.addSelectionHandler(
-                    menuItemValue -> {
-                      checkbox.withValue(menuItem.isSelected(), true);
-                    });
+                    menuItemValue -> checkbox.withValue(menuItem.isSelected(), true));
+
+                menuItem.addDeselectionHandler(
+                    () -> checkbox.withValue(menuItem.isSelected(), true));
               });
         });
   }

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/suggest/MultiSelect.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/suggest/MultiSelect.java
@@ -70,6 +70,7 @@ public static <V> MultiSelect<V> create(String label) {
   /** Default constructor initializing the options menu for multi-selection. */
   public MultiSelect() {
     optionsMenu.setMultiSelect(true);
+    setAutoCloseOnSelect(false);
   }
 
   /**

diff --git a/.../resources/org/dominokit/domino/ui/public/css/domino-ui/dui-components/domino-ui-menu.css b/.../resources/org/dominokit/domino/ui/public/css/domino-ui/dui-components/domino-ui-menu.css
@@ -85,7 +85,6 @@
 .dui-menu-item {
     cursor: pointer;
     text-align: left;
-    padding: var(--dui-menu-item-padding);
     font-style: normal;
     position: relative;
 }
@@ -128,6 +127,7 @@
     text-decoration: none;
     flex-wrap: nowrap;
     flex-basis: 24px;
+    padding: var(--dui-menu-item-padding);
 }
 
 .dui-menu-item-icon {

diff --git a/pom.xml b/pom.xml
@@ -84,7 +84,7 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <elemental2.version>1.2.3</elemental2.version>
-        <gwt.version>2.12.0</gwt.version>
+        <gwt.version>2.12.1</gwt.version>
         <jackson.apt.version>1.0.5</jackson.apt.version>
         <gwt.i18n.version>1.0.2</gwt.i18n.version>
         <domino.doc.tool.version>1.0.0</domino.doc.tool.version>