Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rebranded assets #26

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Add rebranded assets #26

merged 4 commits into from
Feb 6, 2024

Conversation

rgharris
Copy link
Member

@rgharris rgharris commented Feb 2, 2024

Closes ENG-7545

Added a new backlog task ENG-7576 to update the gifs in the README that have the old logo. I'm checking with design to see if we have a logo for the README that will be better in light and dark mode on Github.

Screenshot 2024-02-02 at 11 34 24 AM Screenshot 2024-02-02 at 11 34 37 AM

VS Code Marketplace disallows SVGs
in READMEs.
@rgharris rgharris marked this pull request as draft February 2, 2024 19:47
@rgharris rgharris marked this pull request as ready for review February 2, 2024 19:56
@rgharris rgharris requested a review from nmanoogian February 2, 2024 19:59
@rgharris rgharris requested a review from bvallelunga February 5, 2024 22:42
@nmanoogian
Copy link
Member

@rgharris Looks like Actions may have failed to pick this up. Can you try doing a git commit --amend to dirty the commit and then force push? That might get it working again

@rgharris rgharris force-pushed the rgharris/rebrand branch 4 times, most recently from 6697e6c to 67e7c5e Compare February 6, 2024 16:06
@rgharris rgharris merged commit 7eea995 into master Feb 6, 2024
5 checks passed
@rgharris rgharris deleted the rgharris/rebrand branch February 6, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants