Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 1912 input borderRadius #1916

Merged
merged 3 commits into from
Nov 23, 2023
Merged

fix: 1912 input borderRadius #1916

merged 3 commits into from
Nov 23, 2023

Conversation

pointhalo
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

🇺🇸 English

  • Fix: fix ...

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 17, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b0451b:

Sandbox Source
Semi Design: Simple Story Configuration

@cypress Cypress
Copy link

cypress bot commented Nov 17, 2023

Passing run #2048 ↗︎

0 228 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge e63ea8b into eebded5...
Project: semi-design Commit: 2d51df5a0f ℹ️
Status: Passed Duration: 09:45 💡
Started: Nov 17, 2023 8:39 AM Ended: Nov 17, 2023 8:49 AM

Review all test suite changes for PR #1916 ↗︎

@pointhalo
Copy link
Collaborator Author

@shijiatongxue 确认一下当时为什么这么改，感觉这个 非last child的 border-radius 没有什么作用

@pointhalo pointhalo merged commit e191e97 into main Nov 23, 2023
3 of 6 checks passed
@pointhalo pointhalo deleted the fix-1912 branch November 23, 2023 03:52
DaiQiangReal pushed a commit that referenced this pull request Nov 27, 2023
@pointhalo @DaiQiangReal
fix: input borderRadius when addOnAfter only, close #1912 (#1916)
f3b4c58 
* fix: input addOnAfter only, border radius. close #1912

* fix: input addOnAfter only, border radius. close #1912
DaiQiangReal pushed a commit that referenced this pull request Nov 27, 2023
@pointhalo @DaiQiangReal
fix: input borderRadius when addOnAfter only, close #1912 (#1916)
11e1221 
* fix: input addOnAfter only, border radius. close #1912

* fix: input addOnAfter only, border radius. close #1912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shijiatongxue shijiatongxue shijiatongxue approved these changes

@DaiQiangReal DaiQiangReal Awaiting requested review from DaiQiangReal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pointhalo @shijiatongxue