Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed virtualized Table showHeader bug #726 #1919

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Conversation

shijiatongxue
Copy link
Collaborator

@shijiatongxue shijiatongxue commented Nov 21, 2023

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes virtualized Table showHeader bug #726

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Nov 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 45dff7b:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

Copy link

cypress bot commented Nov 21, 2023

Passing run #2056 ↗︎

0 232 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge d563000 into ff2db7c...
Project: semi-design Commit: 6740c435ba ℹ️
Status: Passed Duration: 10:32 💡
Started: Nov 24, 2023 7:23 AM Ended: Nov 24, 2023 7:34 AM

Review all test suite changes for PR #1919 ↗︎

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff2db7c) 88.10% compared to head (6740c43) 88.09%.

❗ Current head 6740c43 differs from pull request most recent head d563000. Consider uploading reports for the commit d563000 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
- Coverage   88.10%   88.09%   -0.02%     
==========================================
  Files         436      436              
  Lines       25563    25561       -2     
  Branches     6448     6447       -1     
==========================================
- Hits        22522    22517       -5     
- Misses       3041     3044       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shijiatongxue shijiatongxue merged commit db9288a into main Nov 24, 2023
6 checks passed
@shijiatongxue shijiatongxue deleted the fix-726-2 branch November 24, 2023 08:12
DaiQiangReal pushed a commit that referenced this pull request Nov 27, 2023
* fix: fixed virtualized Table showHeader bug #726

* test: resolve Table jest error and add Cypress test case

* test: remove Table huge data demo from chromatic test

---------

Co-authored-by: shijia.me <[email protected]>
DaiQiangReal pushed a commit that referenced this pull request Nov 27, 2023
* fix: fixed virtualized Table showHeader bug #726

* test: resolve Table jest error and add Cypress test case

* test: remove Table huge data demo from chromatic test

---------

Co-authored-by: shijia.me <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants