Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tabs more api #2226

Merged
merged 5 commits into from
May 10, 2024
Merged

feat: add tabs more api #2226

merged 5 commits into from
May 10, 2024

Conversation

DaiQiangReal
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Feat: Tabs 新增 more api,用于将一部分 tabs 收起到下拉菜单中

🇺🇸 English

  • Fix: Tabs has added more API, which is used to collapse some tabs into drop-down menus.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@DaiQiangReal DaiQiangReal requested review from YannLynn and pointhalo May 9, 2024 09:19
Copy link

codesandbox-ci bot commented May 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a141496:

Sandbox Source
pr-story Configuration

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 24.00000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 88.15%. Comparing base (a154de7) to head (11a80d8).

❗ Current head 11a80d8 differs from pull request most recent head 28e98d1. Consider uploading reports for the commit 28e98d1 to get more accurate results

Files Patch % Lines
packages/semi-ui/tabs/TabBar.tsx 25.00% 18 Missing ⚠️
packages/semi-ui/tabs/TabItem.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2226      +/-   ##
==========================================
- Coverage   88.18%   88.15%   -0.03%     
==========================================
  Files         440      440              
  Lines       26030    26050      +20     
  Branches     6641     6645       +4     
==========================================
+ Hits        22954    22965      +11     
- Misses       3076     3085       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented May 9, 2024

Passing run #2481 ↗︎

0 259 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 28e98d1 into a154de7...
Project: semi-design Commit: 11a80d84be ℹ️
Status: Passed Duration: 10:44 💡
Started: May 9, 2024 9:28 AM Ended: May 9, 2024 9:39 AM

Review all test suite changes for PR #2226 ↗︎

@pointhalo pointhalo merged commit b9421f7 into main May 10, 2024
6 of 7 checks passed
@pointhalo pointhalo deleted the feat_tabs_more branch May 10, 2024 12:06
@pointhalo
Copy link
Collaborator

pointhalo commented Jun 17, 2024

image

这个demo太潦草了吧。放一个什么样式都没有的span在这里, 与前面的文字也不在一个轴线上。哪怕放一个 button或者 icon也比这个好呀。
然后demo code 还超长,要横向滚动。阅读体验太差了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants