Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix the upload error icon of the Upload component. The effecti… #2372

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

…ve styles are different due to different css order.;

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #
当前, Upload 组件的上传错误的 icon 的 font-size 设置如下:
image

增加样式优先级,修改后
image

Changelog

🇨🇳 Chinese

  • Style: 增加 Upload 组件中上传错误的 icon 的 font-size 设置的优先级,防止因为编译后 css 文件顺序导致生效的 font-size 不一致问题

🇺🇸 English

  • Style: Increase the priority of the font-size settings of uploaded wrong icons in the Upload component to prevent font-size inconsistencies in effect due to the order of compiled css files.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Sorry, something went wrong.

Copy link

codesandbox-ci bot commented Jul 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1a92330:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Jul 26, 2024

Passing run #2674 ↗︎

0 266 11 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 48091e9 into 0795ac8...
Project: semi-design Commit: 318209ec73 ℹ️
Status: Passed Duration: 10:33 💡
Started: Jul 26, 2024 3:19 AM Ended: Jul 26, 2024 3:30 AM

Review all test suite changes for PR #2372 ↗︎

@YyumeiZhang YyumeiZhang requested a review from YannLynn July 26, 2024 03:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ve styles are different due to different css order
@YyumeiZhang YyumeiZhang force-pushed the style/upload-error-icon branch from 48091e9 to 1a92330 Compare July 26, 2024 03:43
@pointhalo pointhalo merged commit d269c8e into main Jul 26, 2024
7 of 9 checks passed
@pointhalo pointhalo deleted the style/upload-error-icon branch July 26, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants