Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable pre-stop hooks for node daemonset #118

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Rakoth
Copy link

@Rakoth Rakoth commented May 20, 2024

Here are a few changes needed to deal with volume multi-attach error when using karpenter with ebs-csi-driver in eks cluster.

  1. Actualize node cluster-role permissions
  2. Allow empty tolerations for node daemonset, so karpenter will evict it on node shutdown
  3. Make preStop hooks for node containers configurable. Firstly, I added aws-ebs-csi-driver pre-stop-hook by deafult in ebs-plugin container, secondly it is now possible to make sleep pre-stop hook for node-driver-registrar container to give time for others pods to unmount volumes. I did not add this pre-stop hook in defaults because default image is distroless and does not have sleep available (also for this reason current pre-stop hook is always failing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant