Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-toolchain.sh should include isl #460

Open
Jan200101 opened this issue Oct 28, 2023 · 6 comments
Open

build-toolchain.sh should include isl #460

Jan200101 opened this issue Oct 28, 2023 · 6 comments

Comments

@Jan200101
Copy link

build-toolchain.sh currently sets up the gcc build to include gmp, mpc and mpfr but not isl which is also a dependency of gcc.

@Jan200101
Copy link
Author

related issue #312

@rasky
Copy link
Collaborator

rasky commented Oct 28, 2023

I thought isl is optional?

@networkfusion
Copy link
Contributor

@Jan200101 Are you using WSL1 or WSL2 (given you have linked that issue)?!

@Jan200101
Copy link
Author

Jan200101 commented Oct 28, 2023

I thought isl is optional?

Doesn't seem to be from looking at the gcc configure.ac script.
https://gcc.gnu.org/install/prerequisites.html also doesn't mention it as optional (though it doesn't mention anything being optional, just that they could be).

On a CI runner I ran into Unable to find a usable isl. See config.log for details.

Are you using WSL1 or WSL2 (given you have linked that issue)?!

Not using WSL at all, this occured on a Fedora based runner.
I linked the issue because it ran into the same error message

@rasky
Copy link
Collaborator

rasky commented Oct 28, 2023

OK I think the reason I've never realized this is that isl is a dependency also of gmp. So if you install gmp through a package manager, you get isl. And even if you uninstall it to test the gmp source build, there's still isl in your system :)

I guess we need to amend the script to also download and copy isl then.

rasky pushed a commit that referenced this issue Jan 12, 2024
rasky pushed a commit that referenced this issue Jan 12, 2024
@rasky
Copy link
Collaborator

rasky commented Jan 13, 2024

This has been implemented for Mac for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants