Update build-toolchain.sh for mac os #483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request will resolve
#461
It also addresses the isl issue - but only for mac os.
#460
My proposed changes:
I tested this by first removing all homebrew packages:
Then I cloned my modified repo and ran build-toolchain.sh on my m2 pro macbook running Mac OS Sonoma 14.2.1. Libdragon was able to successfully build without issue using these modifications.
Previously I would get errors not being able to find certain tools (like zlib, gcc, binutils, etc.). These errors are addressed by adding to the brew install -q command.
Please note, that I did not test other platforms. I am not sure if this will break regular mac os intel builds or non-mac os builds.