Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings on Perl 5.8.8 when running make #194

Open
atoomic opened this issue Aug 7, 2020 · 1 comment
Open

Warnings on Perl 5.8.8 when running make #194

atoomic opened this issue Aug 7, 2020 · 1 comment

Comments

@atoomic
Copy link
Member

atoomic commented Aug 7, 2020

I noticed these warnings on CentOS 5 using Perl 5.8.8, while testing Devel-PPPort-3.58_01

Steps to reproduce: make clean; perl Makefile.PL && make

# 3.58_01
In file included from RealPPPort.xs:144:
ppport.h: In function ‘DPPP_my_pv_escape’:
ppport.h:16765: warning: pointer targets in passing argument 3 of ‘DPPP_my_utf8_to_uvchr_buf’ differ in signedness
RealPPPort.c:458:1: warning: "croak_xs_usage" redefined
In file included from RealPPPort.xs:144:
ppport.h:14010:1: warning: this is the location of the previous definition
RealPPPort.xs: In function ‘XS_Devel__PPPort_isUTF8_CHAR’:
RealPPPort.xs:3684: warning: passing argument 2 of ‘Perl_is_utf8_string’ discards qualifiers from pointer target type
RealPPPort.c: At top level:
ppport.h:14017: warning: ‘DPPP_my_croak_xs_usage’ defined but not used

I can see similar issues with 3.58, they are not new

#3.58
In file included from RealPPPort.xs:144:
ppport.h: In function ‘DPPP_my_pv_escape’:
ppport.h:10559: warning: pointer targets in passing argument 3 of ‘DPPP_my_utf8_to_uvchr_buf’ differ in signedness
RealPPPort.c:458:1: warning: "croak_xs_usage" redefined
In file included from RealPPPort.xs:144:
ppport.h:7806:1: warning: this is the location of the previous definition
RealPPPort.xs: In function ‘XS_Devel__PPPort_isUTF8_CHAR’:
RealPPPort.xs:3676: warning: passing argument 2 of ‘Perl_is_utf8_string’ discards qualifiers from pointer target type
RealPPPort.c: At top level:
ppport.h:7813: warning: ‘DPPP_my_croak_xs_usage’ defined but not used
atoomic added a commit that referenced this issue Aug 7, 2020
@atoomic
Fix warning croak_xs_usage redefined
ddb1598 
This is fixing a warning from RealPPPort.c
as described in #194.
@atoomic atoomic mentioned this issue Aug 7, 2020
Closed
atoomic added a commit to atoomic/Devel-PPPort that referenced this issue Aug 7, 2020
@atoomic
Fix warning croak_xs_usage redefined
9d08083 
This is fixing a warning from RealPPPort.c
as described in Dual-Life#194.
atoomic added a commit to atoomic/Devel-PPPort that referenced this issue Aug 7, 2020
@atoomic
Fix warning croak_xs_usage redefined
d79a53a 
This is fixing a warning from RealPPPort.c
as described in Dual-Life#194.
atoomic added a commit that referenced this issue Aug 7, 2020
@atoomic
Fix warning croak_xs_usage redefined
0083467 
This is fixing a warning from RealPPPort.c
as described in #194.
@atoomic
Copy link
Member Author

atoomic commented Aug 7, 2020 •
edited
Loading

fixed the croak_xs_usage warning via Perl/perl5#18041

atoomic added a commit to atoomic/Devel-PPPort that referenced this issue Aug 10, 2020
@atoomic
Define PERL_ARGS_ASSERT_CROAK_XS_USAGE when setting croak_xs_usage
f58892b 
This is matching what's done in ExtUtils::ParseXS::Utilities
and avoids to redefine croak_xs_usage later.

References: Dual-Life#194
@atoomic atoomic mentioned this issue Aug 10, 2020
Merged
khwilliamson pushed a commit that referenced this issue Sep 30, 2020
@atoomic @khwilliamson
Define PERL_ARGS_ASSERT_CROAK_XS_USAGE when setting croak_xs_usage
94cca19 
This is matching what's done in ExtUtils::ParseXS::Utilities
and avoids to redefine croak_xs_usage later.

References: #194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atoomic