Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning croak_xs_usage redefined #195

Closed
wants to merge 1 commit into from
Closed

Fix warning croak_xs_usage redefined #195

wants to merge 1 commit into from

Conversation

atoomic
Copy link
Member

@atoomic atoomic commented Aug 7, 2020

This is fixing a warning from RealPPPort.c
as described in #194.

@pali
Copy link
Contributor

pali commented Aug 7, 2020

You cannot undefine this function as it completely breaks croak_xs_usage. See Travis tests https://travis-ci.org/github/Dual-Life/Devel-PPPort/jobs/715934854
PPPort.so: undefined symbol: croak_xs_usage

This is fixing a warning from RealPPPort.c
as described in #194.
@atoomic
Copy link
Member Author

atoomic commented Aug 7, 2020

yeap need a better fix

@atoomic atoomic closed this Aug 7, 2020
@atoomic
Copy link
Member Author

atoomic commented Aug 7, 2020

The redefine is coming from ExtUtils::ParseXS::Utilities
https://metacpan.org/source/SMUELLER/ExtUtils-ParseXS-3.35/lib/ExtUtils/ParseXS/Utilities.pm#L480

@pali
Copy link
Contributor

pali commented Aug 7, 2020

So that is a bug in ExtUtils::ParseXS::Utilities, that it tries to redefine croak_xs_usage even if it is already defined.

I guess it does not cause any problem if ExtUtils::ParseXS::Utilities provides its own implementation and via redefine force usage of own implementation. It just throws harmless warning which can be ignored.

@atoomic
Copy link
Member Author

atoomic commented Aug 7, 2020

I think this is the fix we need
atoomic/perl5@bff94a9

@atoomic
Copy link
Member Author

atoomic commented Aug 7, 2020

But I really wonder if the bug is not a D-PPP issue trying to redefine a function which is going to be set...
Fixing ExtUtils::ParseXS::Utilities have a very low value unless we publish a new version of it upstream....
which did not happened recently

@pali
Copy link
Contributor

pali commented Aug 7, 2020

Devel::PPPort's ppport.h has everything guarded by #ifndef
So I doubt this is Devel::PPPort issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants