Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final fix for overflow bug #169

Closed
wants to merge 6 commits into from
Closed

Conversation

DSSoftware
Copy link

This fix is just a draft.

@DSSoftware
Copy link
Author

Fix for #168 which is not ready xd

@DSSoftware DSSoftware marked this pull request as ready for review July 6, 2023 15:14
@DSSoftware
Copy link
Author

It should be ready, needs review and more tests
@DuckySoLucky

@DSSoftware DSSoftware changed the title Temporary band-aid fix for overflow bug Final fix for overflow bug Jul 10, 2023
@DSSoftware
Copy link
Author

Tested the fix in the guild, should work properly.

@DSSoftware
Copy link
Author

Last commit summary:
Closes #169, #171
The issue with #171 is that filter package throws when there's no letters inside the filtered string.
image

@DuckySoLucky
Copy link
Owner

Last commit summary: Closes #169, #171 The issue with #171 is that filter package throws when there's no letters inside the filtered string. image

okay, gonna test it out in like half hour or so, updating some stuff rn

@DSSoftware DSSoftware closed this Jan 28, 2024
@Zickles
Copy link
Contributor

Zickles commented Jan 28, 2024

💀

@DSSoftware
Copy link
Author

💀

xd we needed more features for the guild and its just pointless to have a incompatible pr with the custom version yk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants