Retry inconsistent downloads #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes similar to upload to retry while we are waiting for the file to be consistent moved some code around since it is used in generic places now
Previous commits in this branch made ProjectStatusMonitor redundant.
dleehr
approved these changes
Aug 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading a file there is a special 404 that has a
resource_not_consistentvalue incode. This occurs when the file url is not currently ready. A background DukeDS process should finish up with the file and we can try again. Similar to what we did with uploads waiting for the project to get ready we will pause and retry. The user will see a message that we are waiting.Fixes #152