Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to #52 (comment) my job is done, pls check
some notes:
/types
folder, it has nothing to do with purpose of this/parent project. There'scarbonphp/carbon-doctrine-types
package as an externalization ofnestbot/carbon
package for this usecase.nesbot/carbon
) all the classes in/types
folder are not usable (lack ofCarbon
namespase)/types
to/tests
, but what are we testing there, if those classes have no sense in the package? I would remove it completely.