refactor: use $push operator in creating transactions

Dwigoric · Nov 19, 2023 · 82acf04 · 82acf04
1 parent 319f95c
commit 82acf04
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/src/routes/deposit-ledgers.js b/src/routes/deposit-ledgers.js
@@ -81,17 +81,18 @@ router.put('/', async (req, res, next) => {
 
         if (!deposit) return res.status(404).json({ error: true, message: 'Deposit not found' })
 
-        const { ledger } = deposit
-
-        // Add transaction to ledger
-        ledger.push({
+        // Construct transaction info
+        const transactionInfo = {
             ...req.body,
             transactionID: Date.now().toString(36).toUpperCase()
-        })
+        }
 
         try {
-            // Update deposit
-            await Deposit.updateOne({ deleted: false, depositID }, { $set: { ledger } })
+            // Add transaction to ledger
+            await Deposit.updateOne(
+                { deleted: false, depositID },
+                { $push: { ledger: transactionInfo } }
+            )
 
             // Return transaction
             return res.status(200).json({ error: false, message: 'Transaction successfully added' })

diff --git a/src/routes/loan-ledgers.js b/src/routes/loan-ledgers.js
@@ -65,17 +65,15 @@ router.put('/', (req, res, next) => {
 
         if (!loan) return res.status(404).json({ error: true, message: 'Loan not found' })
 
-        const { ledger } = loan
-
-        // Add transaction to ledger
-        ledger.push({
+        // Construct transaction info
+        const transactionInfo = {
             ...req.body,
             transactionID: Date.now().toString(36).toUpperCase()
-        })
+        }
 
         try {
-            // Update loan
-            await Loan.updateOne({ deleted: false, loanID }, { $set: { ledger } })
+            // Add transaction to ledger
+            await Loan.updateOne({ deleted: false, loanID }, { $push: { ledger: transactionInfo } })
 
             // Return a 200 response
             return res.status(200).json({ error: false, message: 'Transaction successfully added' })