Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant code #777

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Remove redundant code #777

merged 6 commits into from
Sep 19, 2024

Conversation

bpholt
Copy link
Member

@bpholt bpholt commented Sep 19, 2024

Our Sha256Pipe and KmsAlg have both been superseded by community projects; the former by fs2.hashing.Hashing in fs2 v3.11, and the latter by smithy4s's AWS KMS client generation. We no longer need to maintain either set of functionality.

@bpholt bpholt self-assigned this Sep 19, 2024
@bpholt bpholt requested a review from a team as a code owner September 19, 2024 00:11
@bpholt
Copy link
Member Author

bpholt commented Sep 19, 2024

Ideally we could contribute the Pagination.offsetUnfoldChunkEval code to fs2 as well, and then this whole library could go away!

@bpholt bpholt merged commit b05db67 into 3.x Sep 19, 2024
27 checks passed
@bpholt bpholt deleted the remove-redundant-code branch September 19, 2024 15:14
@bpholt bpholt mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants