Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omega/state time level change #152

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

sbrus89
Copy link

@sbrus89 sbrus89 commented Oct 26, 2024

This PR changes the time level interface in the State class to be consistent with what has been implemented in Tracers.
The new functions getLayerThickness and getNormalVelocity retrieve the device array corresponding to a given TimeLevel. getLayerThicknessH and getNormalVelocityH provide the same functionality for the host arrays. All time index calculations for a given TimeLevel are done in the function getTimeIndex. A getTimeIndex function has been added to the Tracers class as well.

Checklist

  • Documentation:
    • Design document has been generated and added to the docs
    • User's Guide has been updated
    • Developer's Guide has been updated
    • Documentation has been built locally and changes look as expected
  • Testing
    • A comment in the PR documents testing used to verify the changes including any tests that are added/modified/impacted.
    • Unit tests have passed. Please provide a relevant CDash build entry for verification.

@sbrus89 sbrus89 force-pushed the omega/state-time-level-change branch from 592e1a9 to c1ffbb6 Compare October 26, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant