Various updates for MMF needed for integrating into E3SM #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto whannah/pam/MMF-fixes
…o whannah/pam/MMF-fixes
…o whannah/pam/MMF-fixes
…o whannah/pam/MMF-fixes
…nto whannah/pam/MMF-fixes
…o whannah/pam/MMF-fixes
mwarusz
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encompasses a wide range of changes that were needed to integrate PAM as the CRM in E3SM-MMF. This PR is difficult to break into smaller PRs because many of the necessary changes were unknown or not understood when we embarked on the integration. There were many changes to the physics interfaces that were motivated by work by the SCREAM team. Various methods of handling the anelastic reference state were explored before settling on the final treatment.
Other things to note: