Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional refactoring of cmor setup for specific variables (areacella, clisccp, orog, sftlf) #276

Merged
merged 12 commits into from
Sep 10, 2024

Conversation

TonyB9000
Copy link
Contributor

Description

This re-addresses issue #273.

When separating the cmor consolidation material from the logging redesign, I neglected to include the four variable handlers still listed under "vars" (areacella.py, clisccp.py, orog.py, and sftlf.py). Rather than re-open that branch, I created this one.

@TonyB9000
Copy link
Contributor Author

@tomvothecoder As mentioned above, in doing the split of cmor_setup_consolidation with redesigned_logging, I neglected to include the 4 "straggler" handlers listed under "vars" (areacella.py, clisccp.py, orog.py, and sftlf.py). I have since successfully generated "areacella" (one year only). (I had also begun some logging revamp, but backed out those changes).

If you care to review, let me know. I want to have a good rebase to which to apply the logging changes.

@tomvothecoder tomvothecoder changed the title Missed cmor consolidations Additional refactoring of cmor setup for specific variables (areacella, clisccp, orog, sftlf) Sep 9, 2024
Copy link
Collaborator

@tomvothecoder tomvothecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @TonyB9000.

Can you activate your e3sm_to_cmip development environment and run pre-commit install at the base of the e3sm_to_cmip repo directory? This will install the pre-commit hooks that catch issues with linters and automatically formats code using black and isort. More info in the xCDAT docs about pre-commit hooks.

The suggestions I've made in my review here are from those tools. Other than that, looks good to me.

e3sm_to_cmip/cmor_handlers/vars/areacella.py Outdated Show resolved Hide resolved
e3sm_to_cmip/cmor_handlers/vars/clisccp.py Outdated Show resolved Hide resolved
e3sm_to_cmip/cmor_handlers/vars/orog.py Outdated Show resolved Hide resolved
e3sm_to_cmip/cmor_handlers/vars/sftlf.py Outdated Show resolved Hide resolved
e3sm_to_cmip/cmor_handlers/vars/areacella.py Outdated Show resolved Hide resolved
e3sm_to_cmip/cmor_handlers/vars/clisccp.py Outdated Show resolved Hide resolved
e3sm_to_cmip/cmor_handlers/vars/orog.py Outdated Show resolved Hide resolved
e3sm_to_cmip/cmor_handlers/vars/sftlf.py Outdated Show resolved Hide resolved
@TonyB9000
Copy link
Contributor Author

@tomvothecoder Thanks for the pre-commit hooks info. I've installed. I suppose if I wipe/re-clone the repo, or have a repo on another system (chrysalis), I need to re-apply the command(s).

I've applied all the recommended changes and all check passed, so I will (squash and) merge.

@TonyB9000 TonyB9000 merged commit 92be76e into master Sep 10, 2024
5 checks passed
@TonyB9000 TonyB9000 deleted the missed_cmor_consolidations branch September 10, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants