Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak behaviours of build workflow #280

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

altheaden
Copy link
Contributor

Description

Hello! I am making this PR to bring in a few CI changes @xylar and I have been implementing across other repos. These changes include:

  1. cancel_others is now set to false by default, which should make it easier to decipher if a bug is isolated to a specific version of python via CI
  2. All references to mamba/Mambaforge have been removed and/or changed to conda and Miniforge3
  3. The timeout for the pre-commit job has been upped to 5 minutes (we were having jobs occasionally run out of time during the caching step)

For the pre-commit change, I just upped the number in the comment where the current pre-commit settings are listed, but I didn't un-comment anything.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@xylar xylar self-assigned this Sep 21, 2024
@xylar
Copy link
Contributor

xylar commented Sep 21, 2024

@tomvothecoder, could you take a look and make sure you're good with these changes?

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@altheaden, this looks great to me!

Copy link
Collaborator

@tomvothecoder tomvothecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @altheaden! This looks good to merge.

@xylar
Copy link
Contributor

xylar commented Sep 23, 2024

Thanks @tomvothecoder! I'm going to merge this.

@xylar xylar merged commit 857ca10 into E3SM-Project:master Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants