Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch all mamba actions to miniforge/conda #170

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

altheaden
Copy link
Collaborator

@altheaden altheaden commented Jun 28, 2024

In this PR, I updated the build workflow to use miniforge instead of mambaforge. I also made a small change to the pre-commit action that references the README - it was using the old file extension .rst which we just changed to .md in a previous PR.

The testing for this PR will start once the PR is created (as it changes actions that occur at PR-creation time). I will update the testing progress in the comments.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@altheaden altheaden added ci Changes affect github actions CI in progress This PR is not ready for review or merging labels Jun 28, 2024
@altheaden
Copy link
Collaborator Author

It looks to me like all of the environment-related checks worked as expected. @xylar would you mind giving this a look-over to confirm that I set things up the way you intended?

@altheaden altheaden removed the in progress This PR is not ready for review or merging label Jun 28, 2024
@xylar xylar self-requested a review June 29, 2024 10:46
@xylar xylar assigned xylar and altheaden and unassigned xylar Jun 29, 2024
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@altheaden, this looks great! I verified that it's using Miniforge3, as we want:

  Will fetch Miniforge3 latest from https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-x86_64.sh

@xylar
Copy link
Collaborator

xylar commented Jun 29, 2024

@altheaden, please merge when you're ready.

@altheaden altheaden merged commit 99a4b64 into E3SM-Project:main Jul 1, 2024
6 checks passed
@xylar xylar deleted the mamba-actions-to-miniforge branch July 3, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes affect github actions CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants