Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional flags to pip install command #195

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

altheaden
Copy link
Collaborator

In this PR I added a few flags to the python -m pip install [-e] . command. The flags are:

  • -vv indicates very verbose output. This flag is used during the CI runs to help with debugging.
  • --no-deps indicates that pip should not install runtime dependencies from PyPi.
  • --no-build-isolation indicates that pip should not install build time dependencies from PyPi.

Checklist

  • Developer's Guide has been updated
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

@altheaden altheaden added documentation Improvements or additions to documentation ci Changes affect github actions CI labels Sep 23, 2024
@altheaden
Copy link
Collaborator Author

I haven't yet done any testing beyond CI (it doesn't seem necessary to me). I haven't built the documentation but it's such a small change that I don't think it will be necessary.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@altheaden, perfect!

@xylar
Copy link
Collaborator

xylar commented Sep 23, 2024

Yeah, no additional testing seems necessary.

@xylar xylar merged commit 84936cc into E3SM-Project:main Sep 23, 2024
5 checks passed
@altheaden altheaden deleted the pip-install-flags branch September 23, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes affect github actions CI documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants