Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for rc4 #466

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Fixes for rc4 #466

merged 2 commits into from
Aug 4, 2023

Conversation

forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Jul 28, 2023 •
edited
Loading

Fixes for rc4

@forsyth2 forsyth2 added the semver: bug Bug fix (will increment patch version) label Jul 28, 2023
@forsyth2 forsyth2 self-assigned this Jul 28, 2023
@forsyth2 forsyth2 force-pushed the unified-1-9-test branch 2 times, most recently from 58238ff to 460ed43 Compare August 4, 2023 00:20
@forsyth2 forsyth2 changed the title Fix np int issue Fixes for rc4 Aug 4, 2023
@forsyth2 forsyth2 marked this pull request as ready for review August 4, 2023 00:24
@forsyth2
Copy link
Collaborator Author

forsyth2 commented Aug 4, 2023 •
edited
Loading

The second commit undoes the work to test e3sm_to_cmip in its own environment. This implementation was enough for ad-hoc testing, but is not robust enough for production use. In particular, e3sm_to_cmip_environment_commands wasn't set to the ts environment_commands by default, meaning it would always have to be set.

A more robust solution is giving e3sm_to_cmip its own zppy task, as described in #467.

@forsyth2 forsyth2 merged commit 53ae292 into main Aug 4, 2023
4 checks passed
@forsyth2 forsyth2 deleted the unified-1-9-test branch August 4, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@forsyth2 forsyth2

Labels
semver: bug Bug fix (will increment patch version)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@forsyth2