-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paraview: add simple validation test #43
base: master
Are you sure you want to change the base?
Conversation
Since this test is version-restricted the setup should specify something like: |
47376ef
to
d4e1e7c
Compare
This uses ParaView's `Examples` directory to test an installed ParaView. Note that these are only really effective as of 5.11.0-RC2 due to `Examples` having been untested from the top-level prior to this (ParaView runs its example directories individually itself).
d4e1e7c
to
ad15859
Compare
@mathstuf I tried this test after installing [email protected]. It looks like the tests compiled without complaint but the run output looks incorrect to me. No tests were found. I think the setup script needs to load paraview like this: Here's what the test run output looks like:
I can send the build output along if that will help. |
Would the pattern found here be preferred? spack/spack#40112 |
@mathstuf I'm reviewing this test, hoping to get it committed soon, and we actually need to avoid downloading test code during the test. Some platforms don't have external networking available at test time. Can we commit a small chunk of test code directly to the testsuite instead? |
Is the source directory still available? I suppose we could submodule/subrepo it. The problem is likely to be getting the proper version for the installed ParaView. There's no guarantee that a committed |
Nope, we can't rely on source being around in a finished spack-based deployment. This is a common problem for the testsuite. We typically target just versions used in e4s releases and update test code manually as necessary to match the latest release. It's a pain in the neck but very few projects include test code with their install. |
This uses ParaView's
Examples
directory to test an installed ParaView. Note that these are only really effective as of 5.11.0-RC2 due toExamples
having been untested from the top-level prior to this (ParaView runs its example directories individually itself).