MTBLS assignment after validation #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ciliation Email update issue fix and config fix
fix: fixes to create a study and update metadata use cases
…nd some null checks
| @@ -27,7 +27,7 @@ <h3> | |||
| > | |||
| <div class="column"> | |||
| <p class="has-text-centered"> | |||
| <mat-icon>info</mat-icon> Once you create your study, you | |||
| <mat-icon>info</mat-icon> Once you create a request, you | |||
There was a problem hiding this comment.
I would change the wording here, as 'request' is a little unclear - "Once you create a provisonal study - denoted by the identifier REQ (for request)..."
| <p> | ||
| Your study has been assigned the unique identifier | ||
| Your study request has been assigned wit an identifier |
There was a problem hiding this comment.
same here, I would change the wording to something like provisional - 'creating a request is vague'- also need to correct spelling of 'wit'
| <p *ngIf="study" class="step-title"> | ||
| <a | ||
| [ngClass]="{ 'has-text-grey': step < 2 }" | ||
| (click)="redirectTo('info', null, 1)" | ||
| > | ||
| Study Created <br /> | ||
| Request Created <br /> |
There was a problem hiding this comment.
Same here, 'Request Created' is a little vague, especially for users who have used metabolights before (but if the team is happy with it then I'm happy)
| @@ -53,7 +53,7 @@ | |||
| </div> | |||
| <div class="timeline-item"> | |||
| <div class="timeline-marker is-image is-32x32"> | |||
| <img src="https://bulma.io/images/placeholders/32x32.png" /> | |||
| <img src="assets/img/file.png" /> | |||
| </div> | |||
There was a problem hiding this comment.
shouldn't call any asset simply 'file'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.