Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing self-xrefs from release #1665

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

zoependlington
Copy link
Collaborator

@zoependlington zoependlington commented Jul 8, 2022

fixes #752, #684

@matentzn matentzn changed the title Inject subclass dec Removing self-xrefs from release Jul 8, 2022
@dhimmel
Copy link
Contributor

dhimmel commented Jul 11, 2022

Awesome! Thanks @zoependlington and @matentzn for the work on this! So as per remove-internal-xrefs.sparql, this removes any GO, DOID, Orphanet, HP, MONDO, or EFO xrefs where the xreffed term is a class in EFO?

And this removal happens during construction of the release? Such that these xrefs might still be in the source, just that they'll get filtered in the release? Presumably some of these xrefs also exist on EFO supplied terms (rather than just the dynamically imported terms). Would it make sense to also delete these xrefs from the source to avoid future confusion? Not necessarily in this PR.

@matentzn
Copy link
Contributor

My ontology self says yes yes delete in source, but practically I would not recommend it due to the drastic loss of non-recoverable Information (think of future cases where terms are removed from efo or substituted for others, such as orphanet). I would personally recommend to keep them in the edit file (you need to delete them in any case from imported mappings, so the dynamic step in this pr cannot be avoided anyways).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all xrefs to self
3 participants