Migrate to Preact/Vite for better performance #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Optimized images size comparison: Unoptimized (non-webp): Optimized (webp): There is no perceptual difference between the optimized versions and the .png/original versions. I left a couple as png's as they were small enough to not matter, and for those I could notice some difference so I left them as-is. |
vishalkantharaju
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Overall really impressive! Just one small nitpick- as I mentioned earlier, the YouTube video requires 2 clicks to play on Safari. No worries if you don't want to go about debugging this though, you've already done some really cool stuff, and Tanay and I could probably debug when we get a chance too. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally optimized images and youtube embed.
Functionally, the page works exactly the same, except it should (and does) perform better. Vite should also make it easier to work with building and working on the code.
Currently the one problem is that I didn't migrate any of the types, so there are a lot of "react" type errors saying that stuff doesn't exist.