Automation - removing redundant broken test, replacing with more appropriate #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 94.42% | 677/717 |
| 🟢 | Branches | 86.43% | 172/199 |
| 🟢 | Functions | 87.98% | 161/183 |
| 🟢 | Lines | 94.1% | 622/661 |
Test suite run success
362 tests passing in 28 suites.
Report generated by 🧪jest coverage report action from e8dd7a6
mnyamunda-scottlogic
approved these changes
Aug 29, 2024
mwalker-scottlogic
deleted the
test/update-test-snapshot-o3-without-insitu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The summary table regression test 'Verify table shows pollutant data for the timestamp that has the largest deviation - diff 0 - forecast AQI 3, measurement AQI 3' was breaking after recent changes. I don't believe that the behaviour this test was capturing is actually desired. The logic now works that it picks the earlier timeslot when the options are all equal.
Replaced with a test that checks this, and added a test to check for cell colour in summary table when the pollutant values are greater than AQI 6