Accessibility fixes: keyboard navigation to city, and checkbox labels #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
chriswilty
force-pushed
the
keyboard-nav-fixes
branch
from
a3941cd
to
25c9f95
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 65.24% (+0.51% 🔼) |
760/1165 |
| 🔴 | Branches | 49.71% (+0.14% 🔼) |
174/350 |
| 🟡 | Functions | 62.5% (+0.43% 🔼) |
165/264 |
| 🟡 | Lines | 64.37% (+0.53% 🔼) |
701/1089 |
Test suite run success
364 tests passing in 28 suites.
Report generated by 🧪jest coverage report action from c639448
|
Ok, that's looking healthy now. Note I have used |
This comment was marked as outdated.
This comment was marked as outdated.
|
Thank you so much for your work on this and updating the PR, Chris! This is hugely appreciated. I am merging and deploying the changes now. Please note, that we are also switching to a new production sever, so the updated UI will be available at http://136.156.139.13 |
sebsteinig
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noted that it isn't possible to navigate to single city view using keyboard (Enter key), which excludes all those who are unable to use mouse.
This PR addresses that, while also correcting another accessibility issue in which checkboxes were not associated with their label.
I have also tested these changes using NVDA screen reader, and they work as expected.
resolves #350