-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Rename Efield/Bfield to E/B #5315
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a decent search and replace refactor. I am happy to not have to type the word 'field' nearly as often in the future.
@RemiLehe this needs a small update for merge conflicts please :) In tests, it looks like only
|
@@ -134,7 +134,7 @@ This example accesses the :math:`E_x(x,y,z)` field at level 0 after every time s | |||
warpx = sim.extension.warpx | |||
|
|||
# data access | |||
E_x_mf = warpx.multifab(f"Efield_fp[x][level=0]") | |||
E_x_mf = warpx.multifab(f"E_fp[x][level=0]") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed to E_x_mf = warpx.multifab("E_fp", dir=0, level=0)
in a later PR if not already fixed.
This makes names shorter and more consistent.
This is a breaking change for Python users that access he E- and B-field directly by name.
Was, e.g.,:
is now:
For:
Efield_...
Bfield_...
.._fp
,..._cp
,..._aux
,..._cax
,..._fp_external
,..._avg_fp
,..._avg_cp