Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Run tests #7

wants to merge 6 commits into from

Conversation

streeve
Copy link
Member

@streeve streeve commented Jul 29, 2020

Run with gtest

Clean up test names and compile warnings

@streeve streeve force-pushed the tests branch 15 times, most recently from 42e86ec to 997499b Compare July 29, 2020 06:27
@junghans
Copy link
Member

And now we have a segfault.

@streeve
Copy link
Member Author

streeve commented Jul 29, 2020

I don't understand why it warns that it's skipping that test because of PGI/Cuda, but then fails on it later

@junghans
Copy link
Member

Well the test gets added before the compiler is actually checked.

@junghans
Copy link
Member

The test is still added for Kokkos_ENABLE_OPENMP, @guangyechen / @rfbird can you have a look why it segfaults?

@rfbird
Copy link

rfbird commented Jul 30, 2020

The test is still added for Kokkos_ENABLE_OPENMP, @guangyechen / @rfbird can you have a look why it segfaults?

I'll take a look

@rfbird
Copy link

rfbird commented Jul 30, 2020

So, I can't get this to fail locally or on a super (darwin). What's the best way to debug it without just add a bunch of spam prints and abusing GH actions?

Also, why is this hard coded to use OpenMP vs Kokkos::DefaultExecutionSpace or something?

Finally, shall we rename the tests to better match the files/examples they come from?

Fortran_advance_example_04 is build from ../advanced_examples/04_unmanaged_aosoa, maybe it would be better if the test had unmanaged_aosoa in the name or something?

@streeve
Copy link
Member Author

streeve commented Aug 4, 2020

So, I can't get this to fail locally or on a super (darwin). What's the best way to debug it without just add a bunch of spam prints and abusing GH actions?

I tried on summit and got all four to segfault, but someone that knows Fortran would be a lot more helpful

Also, why is this hard coded to use OpenMP vs Kokkos::DefaultExecutionSpace or something?

I left it so far because of some explicit omp_get_thread_num etc.

Finally, shall we rename the tests to better match the files/examples they come from?

Fortran_advance_example_04 is build from ../advanced_examples/04_unmanaged_aosoa, maybe it would be better if the test had unmanaged_aosoa in the name or something?

Agreed, I changed the name of the tests

@rfbird
Copy link

rfbird commented Aug 4, 2020

So, I can't get this to fail locally or on a super (darwin). What's the best way to debug it without just add a bunch of spam prints and abusing GH actions?

I tried on summit and got all four to segfault, but someone that knows Fortran would be a lot more helpful

Also, why is this hard coded to use OpenMP vs Kokkos::DefaultExecutionSpace or something?

I left it so far because of some explicit omp_get_thread_num etc.

Finally, shall we rename the tests to better match the files/examples they come from?
Fortran_advance_example_04 is build from ../advanced_examples/04_unmanaged_aosoa, maybe it would be better if the test had unmanaged_aosoa in the name or something?

Agreed, I changed the name of the tests

I'd be happy to help out if you wanted to debug this together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants