-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create semi-structured Hypre solver interface for multi-variate systems #632
Conversation
…ce in Cajita Process for setting matrix values and vector values for solver incomplete Needs to be generalized from 3-D, 3-variate to N-Dim, N_v-variate
…tial unit test and example for the solver
Adds calls to HYPRE_Init and HYPRE_Finalize to the hypre structured s…
…t the preconditioner in the example
…HypreStructuredSolver header file
Merging synced remote branch to local changes for handling the hypre init and finalize calls
Needs fix to handling stencil indices for multi-variate coupled problems
issue in creation of view in multi-variate unit test needs to be fixed
…vectors. Still not functional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to merge/rebase master because of your previous PR
…ulti-variate case. Additional cleanups to hypre semi-structured solver included
Conflicts: cajita/unit_test/tstHypreStructuredSolver2d.hpp cajita/unit_test/tstHypreStructuredSolver3d.hpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be back tomorrow if you want to chat about my comments
Creates Hypre.hpp header for initalizing hypre backend for both strucutred and semi-structured solvers. Passes variable filename to hypre print functions instead of hard-coding the output file names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little bit more cleanup, a few comments left over from before
...ple/cajita_tutorial/11_semi_structured_solver_hypre/hypre_semi_structured_solver_example.cpp
Outdated
Show resolved
Hide resolved
example/cajita_tutorial/11_semi_structured_solver_multi_variate/CMakeLists.txt
Outdated
Show resolved
Hide resolved
example/cajita_tutorial/11_structured_solver_hypre/hypre_structured_solver_example.cpp
Outdated
Show resolved
Hide resolved
@kwitaechong this needs a review for the new test and solver itself |
...orial/11_semi_structured_solver_multi_variate/hypre_semi_structured_solver_multi_example.cpp
Outdated
Show resolved
Hide resolved
example/cajita_tutorial/11_structured_solver_hypre/hypre_structured_solver_example.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking for one more review from @kwitaechong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done navigating the semi-structured interface for multivariate implicit solves!
…ms (ECP-copa#632) Also adds calls to HYPRE_Init and HYPRE_Finalize to the hypre structured solver Does not support PFMG or Jacobi preconditioner options
Creates a new solver wrapper for semi-structured solvers in hypre, which will allow for multi-variate problems. Unit test and example problem are included which correspond to the same problem as the unit test and example for the structured solver. Currently, pre-conditioners are not functioning with this solver wrapper and the multi-variate capacity is not fully tested