Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve HDF5 CMake requirements #640

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Improve HDF5 CMake requirements #640

merged 3 commits into from
Jun 30, 2023

Conversation

streeve
Copy link
Member

@streeve streeve commented Jun 9, 2023

  • Fail if non-MPI HDF5 is enabled
  • Prefer parallel over serial HDF5 (since serial isn't supported)

@streeve streeve added the bug Something isn't working label Jun 9, 2023
@streeve streeve requested a review from guangyechen June 9, 2023 15:51
@streeve streeve self-assigned this Jun 9, 2023
@streeve
Copy link
Member Author

streeve commented Jun 9, 2023

@brtnfld just making sure this is reasonable

@streeve
Copy link
Member Author

streeve commented Jun 9, 2023

@guangyechen hopefully this makes your recent issue more clear

@guangyechen
Copy link
Collaborator

I don't seem to have hdf5-parallel in my system, but compilation with module load hdf5 seems working.

@brtnfld
Copy link
Contributor

brtnfld commented Jun 9, 2023

Looks reasonable.

@streeve
Copy link
Member Author

streeve commented Jun 9, 2023

@junghans I don't understand why the ubuntu hdf5 thinks it's not parallel

@junghans
Copy link
Member

junghans commented Jun 9, 2023

I have no idea.

@streeve streeve requested a review from junghans June 27, 2023 15:14
@junghans
Copy link
Member

@rbberger could you review this?

@streeve
Copy link
Member Author

streeve commented Jun 30, 2023

HIP timeout unrelated

@streeve streeve merged commit 645f868 into ECP-copa:master Jun 30, 2023
31 checks passed
@streeve streeve deleted the fixup_find_hdf5 branch June 30, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbberger rbberger rbberger left review comments

@brtnfld brtnfld brtnfld left review comments

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

@guangyechen guangyechen guangyechen approved these changes

@junghans junghans Awaiting requested review from junghans

Assignees

@streeve streeve

Labels
bug Something isn't working ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@streeve @guangyechen @brtnfld @junghans @rbberger @jhendersonHDF