Adds HDF5 option to use subfiling #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendersonHDF
approved these changes
Jun 30, 2023
|
@streeve, I've finished the advanced HDF5 example. |
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
======================================
Coverage 95.2% 95.2%
======================================
Files 51 51
Lines 6297 6309 +12
======================================
+ Hits 5997 6009 +12
Misses 300 300
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I don't think CI will test these PR features since it needs HDF5 > =1.14, and I don't think any distros have it by default. |
|
Added to CI: building HDF5 version 1.14.3 for testing with subfiling. |
|
Just rebased and pushed (I kept a backup copy of your branch as well) - one quick question for when subfiling isn't available and I think it's ready to merge. Thanks for all your time on this! |
|
What was the question about if subfiling is not available? |
streeve
approved these changes
Jan 12, 2024
|
HIP timeout unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/HDFGroup/hdf5doc/blob/master/RFCs/HDF5_Library/VFD_Subfiling/user_guide/HDF5_Subfiling_VFD_User_s_Guide.pdf
Subfiling can be configured either through environment variables or APIs.