Add HIP support for HYPRE #658
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR adds a FindHYPRE cmake to be used in the case of Kokkos HIP builds, in which there is currently no supported CMake installation method for hypre builds on AMD. |
junghans
reviewed
Aug 8, 2023
junghans
reviewed
Aug 28, 2023
junghans
reviewed
Aug 28, 2023
junghans
reviewed
Aug 28, 2023
streeve
force-pushed
the
find-hypre-cmake
branch
2 times, most recently
from
bcd4e05
to
e5d1a62
Compare
streeve
changed the title
streeve
force-pushed
the
find-hypre-cmake
branch
3 times, most recently
from
3925163
to
f22edeb
Compare
Co-authored-by: Christoph Junghans <[email protected]> Co-authored-by: Sam Reeve <[email protected]>
streeve
force-pushed
the
find-hypre-cmake
branch
from
f22edeb
to
72f866d
Compare
|
Okay @junghans failure here is finally just missing the right target |
junghans
reviewed
Sep 15, 2023
Co-authored-by: Christoph Junghans <[email protected]>
|
@junghans I tried some more in a container, but I don't see any pkg-config content from hypre anywhere.. If we point to that correctly I think it will finally work |
junghans
reviewed
Sep 21, 2023
| Cabana_add_dependency( PACKAGE HYPRE VERSION 2.22.1 ) | ||
| if(Kokkos_ENABLE_HIP) | ||
| # FIXME: remove when hypre supports HIP CMake builds | ||
| pkg_check_modules(PC_HYPRE hypre REQUIRED IMPORTED_TARGET) |
There was a problem hiding this comment.
We need to add logic for Cabana_ENABLE_HYPRE here, too.
|
Now blocked by #697 |
|
Should be able to close/replace once https://github.com/hypre-space/hypre/tree/cmake-hip is merged @victorapm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added FindHYPRE cmake for autotools install in lieu of available CMake installation.Uses pkgconfig instead in lieu of available CMake installation