Create neighbor list histograms #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streeve
force-pushed
the
neighbor_histogram
branch
from
b663874
to
bfc4e51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
========================================
+ Coverage 96.4% 96.5% +0.1%
========================================
Files 90 92 +2
Lines 14498 14711 +213
========================================
+ Hits 13977 14201 +224
+ Misses 521 510 -11 ☔ View full report in Codecov by Sentry. |
streeve
force-pushed
the
neighbor_histogram
branch
from
bfc4e51
to
89e2c81
Compare
lebuller
reviewed
Nov 28, 2023
lebuller
reviewed
Nov 29, 2023
streeve
force-pushed
the
neighbor_histogram
branch
5 times, most recently
from
4bf7c6b
to
5ec7a97
Compare
Co-authored-by: Sam Reeve <[email protected]>
streeve
force-pushed
the
neighbor_histogram
branch
from
5ec7a97
to
5d58d8d
Compare
|
retest this please. |
lebuller
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method to construct neighbor histograms.
Missing test and need to decide whether we output bin edge vs bin center