HYPRE memory fixup #733
Merged
HYPRE memory fixup #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialize in HYPRE. Some leak still present in call to setupImpl which is likely a HYPRE issue
|
Do you think we should merge or wait until we figure out the |
I think it may be good to go ahead and merge since this will fix a lot of the memory issue we've seen. Though we can wait to discuss on the call this afternoon |
streeve
reviewed
Jan 16, 2024
streeve
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes calls to HYPRE initialize functions for vectors or matrices in
setMatrixValuesandsolveas that leads to a memory leak. May still need more thought in how these functions are called as the way they are used by HYPRE is not the clearest/most logical.Some leak still present in the
setupfunction, specifically in the implementation ofsetupImpl. AssetupImplmainly just passes data to HYPRE, it is likely an issue on their end. This issue appears to be less significant than the issue insetMatrixValuesbut should still be remedied