2d neighbors #755
Open
2d neighbors #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streeve
force-pushed
the
2d_neighbors
branch
5 times, most recently
from
4ca30da
to
ec1acc4
Compare
|
Ok @lebuller this is ready for review. Looking into a good way to do the ArborX lists and planning to add 2d tests, but otherwise ready. Also probably good to move those last two commits to a separate PR if you agree |
What do you mean by "good way to do the ArborX lists"? |
streeve
force-pushed
the
2d_neighbors
branch
2 times, most recently
from
6212f87
to
f481b33
Compare
Haven't tried yet, but I'd like to extract the dimension from the positions directly. Which would be nice across all cases honestly |
|
Looks mostly good to me, we should probably add tests of the 2D list capabilities as well which don't seem to be included |
2d LinkedCellList CartesianGrid
2d neighbor discriminators
streeve
force-pushed
the
2d_neighbors
branch
from
521a986
to
d832351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing 2d tests
Part of #490