-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored into library and MD bin. #31
Conversation
@junghans any comments on CMake style? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small changes. Probably easiest to wait until #32 is merged; there's quite a bit shifting with the Kokkos/Cabana updates
bin/CMakeLists.txt
Outdated
@@ -0,0 +1,4 @@ | |||
|
|||
add_executable(MD main.cpp) | |||
target_link_libraries(MD LINK_PUBLIC CabanaMD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe cbnMD
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adopted.
@frobnitzem should be fine to update - the CMake is even simpler now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Ready to merge, @frobnitzem?
Yes, I think this one is ready. Did I miss a checkbox somewhere? |
Nope, just wanted to make sure |
I'm trying to create a Monte Carlo program from this, and have the following roadmap in-mind:
This is step 1. Not being a cmake expert, I don't know if
bin/CMakeLists.txt
is too verbose. I think it doesn't need Kokkos::kokkos under under target_link_libraries, but maybe some of the others are redundant too because of cmake's linking rules.